ShogunIsHere/spotify-manager
1
0
Fork 0
mirror of https://github.com/20kaushik02/spotify-manager.git synced 2026-01-25 06:04:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

error handling robustness, logger corrections, better playlist-editable checking

Browse Source
This commit is contained in:
Kaushik Narayan R
2025-03-14 20:44:37 -07:00
parent ef3a055c06
commit 14eeb57a0e
4 changed files with 76 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
api/spotify.ts
View File

@@ -98,7 +98,8 @@ const singleRequest = async <RespDataType>({
message = message.concat(
`${error.response.status} - ${error.response.data?.error?.message}`
);
res?.status(error.response.status).send(error.response.data);
if (res && !res.headersSent)
res.status(error.response.status).send(error.response.data);
logger.warn(message, {
response: {
data: error.response.data,
@@ -109,13 +110,14 @@ const singleRequest = async <RespDataType>({
} else if (error.request) {
// Request sent, but no response received
message = message.concat("No response");
res?.status(504).send({ message });
if (res && !res.headersSent) res.status(504).send({ message });
logger.error(message, { error });
return { error, message };
} else {
// Something happened in setting up the request that triggered an Error
message = message.concat("Request failed");
res?.status(500).send({ message: "Internal Server Error" });
if (res && !res.headersSent)
res.status(500).send({ message: "Internal Server Error" });
logger.error(message, { error });
return { error, message };
}
@@ -168,9 +170,7 @@ const getCurrentUsersPlaylistsNextPage: (
});
};
interface GetPlaylistDetailsFirstPageArgs
extends Omit<EndpointHandlerWithResArgs, "res"> {
res?: Res;
interface GetPlaylistDetailsFirstPageArgs extends EndpointHandlerWithResArgs {
initialFields: string;
playlistID: string;
}
@@ -257,9 +257,7 @@ const removePlaylistItems: (
// non-endpoints, i.e. convenience wrappers
// ---------
interface CheckPlaylistEditableArgs
extends Omit<EndpointHandlerWithResArgs, "res"> {
res?: Res;
interface CheckPlaylistEditableArgs extends EndpointHandlerWithResArgs {
playlistID: string;
userID: string;
}
@@ -276,14 +274,13 @@ const checkPlaylistEditable: (
playlistID,
userID,
}) => {
let checkFields = ["collaborative", "owner(id)"];
let args: GetPlaylistDetailsFirstPageArgs = {
let checkFields = ["collaborative", "owner(id)", "name"];
const { resp, error, message } = await getPlaylistDetailsFirstPage({
res,
authHeaders,
initialFields: checkFields.join(),
playlistID,
};
if (res) args.res = res;
const { resp, error, message } = await getPlaylistDetailsFirstPage(args);
});
if (!resp) return { status: false, error, message };
// https://web.archive.org/web/20241226081630/https://developer.spotify.com/documentation/web-api/concepts/playlists#:~:text=A%20playlist%20can%20also%20be%20made%20collaborative