ShogunIsHere/spotify-manager
1
0
Fork 0
mirror of https://github.com/20kaushik02/spotify-manager.git synced 2026-01-25 06:04:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

tidying up redis' remains while shifting to sqlite, DRYer 500 responses

Browse Source
This commit is contained in:
Kaushik Narayan R
2024-07-24 20:09:54 +05:30
parent 5803c997b2
commit 40cf0c2e2b
8 changed files with 1285 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
controllers/auth.js
View File

@@ -29,7 +29,7 @@ const login = (_req, res) => {
);
} catch (error) {
logger.error('login', { error });
return res.status(500).send({ message: "Server Error. Try again." });
return res.sendStatus(500);
}
}
@@ -68,7 +68,7 @@ const callback = async (req, res) => {
logger.info('New login.');
req.session.accessToken = response.data.access_token;
req.session.refreshToken = response.data.refresh_token;
req.session.cookie.maxAge = 7776000000 // 90 days, arbitrary
req.session.cookie.maxAge = 7 * 24 * 60 * 60 * 1000 // 1 week
req.session.save((err) => {
if (err) {
@@ -87,7 +87,7 @@ const callback = async (req, res) => {
}
} catch (error) {
logger.error('callback', { error });
return res.status(500).send({ message: "Server Error. Try again." });
return res.sendStatus(500);
}
}
@@ -110,7 +110,7 @@ const refresh = async (req, res) => {
if (response.status === 200) {
req.session.accessToken = response.data.access_token;
req.session.refreshToken = response.data.refresh_token ?? req.session.refreshToken; // refresh token rotation
req.session.cookie.maxAge = 7776000000 // 90 days, arbitrary
req.session.cookie.maxAge = 7 * 24 * 60 * 60 * 1000 // 1 week
logger.info(`Access token refreshed${(response.data.refresh_token !== null) ? ' and refresh token updated' : ''}.`);
return res.status(200).send({
@@ -122,7 +122,7 @@ const refresh = async (req, res) => {
}
} catch (error) {
logger.error('refresh', { error });
return res.status(500).send({ message: "Server Error. Try again." });
return res.sendStatus(500);
}
};
@@ -134,7 +134,7 @@ const refresh = async (req, res) => {
const logout = async (req, res) => {
try {
const delSession = req.session.destroy((err) => {
if (Object.keys(err).length) { // err is empty obj if no error
if (err) {
logger.error("Error while logging out", { err });
return res.sendStatus(500);
} else {
@@ -145,7 +145,7 @@ const logout = async (req, res) => {
})
} catch (error) {
logger.error('logout', { error });
return res.status(500).send({ message: "Server Error. Try again." });
return res.sendStatus(500);
}
}

4
controllers/playlists.js
View File

@@ -73,7 +73,7 @@ const getUserPlaylists = async (req, res) => {
return res.status(200).send(playlists);
} catch (error) {
logger.error('getUserPlaylists', { error });
return res.status(500).send({ message: "Server Error. Try again." });
return res.sendStatus(500);
}
}
@@ -155,7 +155,7 @@ const getPlaylistDetails = async (req, res) => {
return res.status(200).send(playlist);
} catch (error) {
logger.error('getPlaylistDetails', { error });
return res.status(500).send({ message: "Server Error. Try again." });
return res.sendStatus(500);
}
}