another day, another correction/improvement/refactor commit

api/axios.js

@@ -0,0 +1,51 @@
+const axios = require('axios');
+
+const { baseAPIURL, accountsAPIURL } = require("../constants");
+const logger = require('../utils/logger')(module);
+
+const authInstance = axios.default.create({
+	baseURL: accountsAPIURL,
+	timeout: 20000,
+	headers: {
+		'Content-Type': 'application/x-www-form-urlencoded',
+		'Authorization': 'Basic ' + (Buffer.from(process.env.CLIENT_ID + ':' + process.env.CLIENT_SECRET).toString('base64'))
+	},
+});
+
+const axiosInstance = axios.default.create({
+	baseURL: baseAPIURL,
+	timeout: 20000,
+	headers: {
+		'Content-Type': 'application/json'
+	},
+});
+
+axiosInstance.interceptors.request.use(config => {
+	logger.http("API call", {
+		url: config.url,
+		method: config.method,
+		params: config.params ?? {},
+		headers: Object.keys(config.headers),
+	});
+	return config;
+});
+
+axiosInstance.interceptors.response.use(
+	(response) => response,
+	(error) => {
+		logger.warn("AxiosError", {
+			error: {
+				name: error.name,
+				code: error.code,
+				message: error.message,
+			},
+			req: error.config,
+		});
+		return Promise.reject(error);
+	}
+);
+
+module.exports = {
+	authInstance,
+	axiosInstance
+};

api/spotify.js

@@ -0,0 +1,140 @@
+
+const logger = require("../utils/logger")(module);
+
+const typedefs = require("../typedefs");
+
+const { axiosInstance } = require("./axios");
+
+const logPrefix = "Spotify API: ";
+
+/**
+ * Spotify API - one-off request handler
+ * @param {typedefs.Req} req convenient auto-placing headers from middleware (not a good approach?)
+ * @param {typedefs.Res} res handle failure responses here itself (not a good approach?)
+ * @param {import('axios').Method} method HTTP method
+ * @param {string} path request path
+ * @param {import('axios').AxiosRequestConfig} config request params, headers, etc.
+ * @param {any} data request body
+ * @param {boolean} inlineData true if data is to be placed inside config
+ */
+const singleRequest = async (req, res, method, path, config = {}, data = null, inlineData = false) => {
+	let resp;
+	config.headers = { ...config.headers, ...req.sessHeaders };
+	try {
+		if (!data || (data && inlineData)) {
+			if (data)
+				config.data = data ?? null;
+			resp = await axiosInstance[method.toLowerCase()](path, config);
+		} else
+			resp = await axiosInstance[method.toLowerCase()](path, data, config);
+
+		logger.debug(logPrefix + "Successful response received.");
+		return resp;
+	} catch (error) {
+		if (error.response) {
+			// Non 2XX response received
+			let logMsg;
+			if (error.response.status >= 400 && error.response.status < 600) {
+				res.status(error.response.status).send(error.response.data);
+				logMsg = '' + error.response.status
+			}
+			else {
+				res.sendStatus(error.response.status);
+				logMsg = "???";
+			}
+			logger.error(logPrefix + logMsg, {
+				response: {
+					data: error.response.data,
+					status: error.response.status,
+				}
+			});
+		} else if (error.request) {
+			// No response received
+			res.sendStatus(504);
+			logger.warn(logPrefix + "No response", { error });
+		} else {
+			// Something happened in setting up the request that triggered an Error
+			res.sendStatus(500);
+			logger.error(logPrefix + "Request failed?", { error });
+		}
+
+		return null;
+	};
+}
+
+const getUserProfile = async (req, res) => {
+	const response = await singleRequest(req, res,
+		"GET", "/me",
+		{ headers: { Authorization: `Bearer ${req.session.accessToken}` } }
+	);
+	return res.headersSent ? null : response.data;
+}
+
+const getUserPlaylistsFirstPage = async (req, res) => {
+	const response = await singleRequest(req, res,
+		"GET",
+		`/users/${req.session.user.id}/playlists`,
+		{
+			params: {
+				offset: 0,
+				limit: 50,
+			},
+		});
+	return res.headersSent ? null : response.data;
+}
+
+const getUserPlaylistsNextPage = async (req, res, nextURL) => {
+	const response = await singleRequest(
+		req, res, "GET", nextURL);
+	return res.headersSent ? null : response.data;
+}
+
+const getPlaylistDetailsFirstPage = async (req, res, initialFields, playlistID) => {
+	const response = await singleRequest(req, res,
+		"GET",
+		`/playlists/${playlistID}/`,
+		{
+			params: {
+				fields: initialFields
+			},
+		});
+	return res.headersSent ? null : response.data;
+}
+
+const getPlaylistDetailsNextPage = async (req, res, nextURL) => {
+	const response = await singleRequest(
+		req, res, "GET", nextURL);
+	return res.headersSent ? null : response.data;
+}
+
+const addItemsToPlaylist = async (req, res, nextBatch, playlistID) => {
+	const response = await singleRequest(req, res,
+		"POST",
+		`/playlists/${playlistID}/tracks`,
+		{},
+		{ uris: nextBatch }, false
+	)
+	return res.headersSent ? null : response.data;
+}
+
+const removeItemsFromPlaylist = async (req, res, nextBatch, playlistID, snapshotID) => {
+	const response = await singleRequest(req, res,
+		"DELETE",
+		`/playlists/${playlistID}/tracks`,
+		{},
+		// axios delete method doesn't have separate arg for body so hv to put it in config
+		{ positions: nextBatch, snapshot_id: snapshotID }, true
+	);
+	return res.headersSent ? null : response.data;
+}
+
+module.exports = {
+	singleRequest,
+	getUserProfile,
+	getUserPlaylistsFirstPage,
+	getUserPlaylistsNextPage,
+	getPlaylistDetailsFirstPage,
+	getPlaylistDetailsNextPage,
+	addItemsToPlaylist,
+	removeItemsFromPlaylist,
+}